Skip to content

fix: proxy auth signing and project root resolution#367

Merged
iamgp merged 4 commits intomainfrom
codex/fix-proxy-auth-and-project-path
Apr 7, 2026
Merged

fix: proxy auth signing and project root resolution#367
iamgp merged 4 commits intomainfrom
codex/fix-proxy-auth-and-project-path

Conversation

@iamgp
Copy link
Copy Markdown
Collaborator

@iamgp iamgp commented Apr 6, 2026

Summary

  • bind proxy shared-secret signatures to asserted identity headers so header swaps fail verification
  • load proxy shared-secret and header override env vars through the normal provider registration path
  • keep PHLO_PROJECT_PATH accepting explicit absolute roots while still rejecting raw path traversal segments
  • preserve hook filter matching when filters.tags is unset

Root cause

The hardening patch only signed timestamp/remote/path, so trusted identity headers could be changed after signing, and the new shared secret was not wired into environment-driven provider setup. The project-root validation also overconstrained explicit absolute paths used by child processes and CI. Separately, hook filter tag matching used negated boolean logic that incorrectly rejected events when filters.tags was None.

Validation

  • uv run pytest tests/test_authentication_provider.py
  • uv run pytest tests/test_infrastructure_config.py
  • uv run pytest tests/test_hook_bus.py
  • make typecheck-python
  • uv run ruff check src/phlo/capabilities/authentication.py src/phlo/infrastructure/config.py src/phlo/cli/commands/schema_migrate.py tests/test_authentication_provider.py tests/test_infrastructure_config.py docs/setup/security.md

Closes #338
Closes #339
Closes #344


Open with Devin

@iamgp iamgp changed the title [codex] fix proxy auth signing and project root resolution fix: proxy auth signing and project root resolution Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

Cairn Quality Report

Commit: 4c50bc6 · View full report

Checker Status ✅ Passed ❌ Failed Items
ruff passed 0 0 0
ruff-format pass 0 0 1
pytest-3.11 passed 410 0 411
pytest-3.12 passed 410 0 411

@iamgp iamgp marked this pull request as ready for review April 6, 2026 22:03
devin-ai-integration[bot]

This comment was marked as resolved.

@iamgp iamgp merged commit 764ff20 into main Apr 7, 2026
42 checks passed
@iamgp iamgp deleted the codex/fix-proxy-auth-and-project-path branch April 7, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant